Rename pre-refactor lecture files to current source slugs; drop 3 superseded#99
Merged
Conversation
…erseded Aligns the 8 orphaned files with the source reorganisation in lecture-python.myst (commits b7c6464 and b27f1eb, Nov 2025): Renamed (translation preserved, content resync follows in the Track B wave): - cake_eating_problem.md -> os.md - cake_eating_numerical.md -> os_numerical.md - optgrowth.md -> os_stochastic.md - ifp.md -> ifp_egm.md - mccall_correlated.md -> mccall_persist_trans.md Removed (deleted upstream in the cake-eating refactor; successors os_time_iter/os_egm/os_egm_jax are new untranslated lectures, Phase 2): - optgrowth_fast.md - coleman_policy_iter.md - egm_policy_iter.md Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
✅ Deploy Preview for astonishing-narwhal-a8fc64 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
This PR aligns the Chinese lecture slugs with the upstream (Nov 2025) reorganization by introducing the new filenames/paths and updating the book TOC, while removing several upstream-deleted lectures.
Changes:
- Added new lecture files under the current upstream slugs (
os*,ifp_egm,mccall_persist_trans). - Removed superseded lectures (
optgrowth_fast,coleman_policy_iter,egm_policy_iter). - Updated
lectures/_toc.ymlto reflect the new structure.
Reviewed changes
Copilot reviewed 4 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| lectures/os.md | Adds the “Optimal Savings / cake-eating” lecture under the new os slug. |
| lectures/os_numerical.md | Adds the numerical-methods follow-up under the new os_numerical slug. |
| lectures/os_stochastic.md | Adds the stochastic optimal growth lecture under the new os_stochastic slug. |
| lectures/ifp_egm.md | Adds the income fluctuation problem lecture under the new ifp_egm slug. |
| lectures/mccall_persist_trans.md | Adds the “correlated offers” McCall variant under the new mccall_persist_trans slug. |
| lectures/optgrowth_fast.md | Removes the upstream-superseded lecture. |
| lectures/coleman_policy_iter.md | Removes the upstream-superseded lecture. |
| lectures/egm_policy_iter.md | Removes the upstream-superseded lecture. |
| lectures/_toc.yml | Repoints the book structure to the new slugs and drops removed lectures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+82
to
86
| - file: os | ||
| - file: os_numerical | ||
| - file: os_stochastic | ||
| - file: ifp_egm | ||
| - file: ifp_advanced |
10 tasks
mmcky
added a commit
that referenced
this pull request
Jul 18, 2026
#97) (#166) * CI hardening: strict builds, conda dependabot, missing wald_dec_rule.png Carries forward the pieces of #97 that #165 did not supersede: - jb build gains '-n -W --keep-going' in cache/ci/publish workflows, matching the English source repos' strict-build convention - dependabot watches the conda ecosystem (jupyter-book pinned <2.0, python constrained by the anaconda distribution) - wald_dec_rule.png copied from the source repo (referenced by wald_friedman_2 but absent here - a warning today, an error under -W) Dropped from #97 as obsolete: the lecture-code fixes (regenerated by the Track B resync wave or applied directly to its branches) and the ogm.py tweak (optgrowth_fast was removed in #99). Part of Phase 0 Track B, QuantEcon/lecture-python.myst#947. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * Fix the two main-content strict-build breaks: mix_model import, cass_fiscal ref mix_model kept a CJK font-config block without the mpl import it needs (same class as the five wave-branch fixes; mix_model was skipped by the wave so the pre-existing bug stayed on main). cass_fiscal's note pointed {doc} at a document that never existed; replaced with the wave branch's exact {ref}`growth_model` sentence so the resync PR merges cleanly over it. newton_method's two iref_ambiguous warnings are NOT patched here: old main lacks the local anchors, and the resync PR (#140) adds them - merging #140 resolves those warnings without conflict-prone edits. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of Phase 0 Track B (QuantEcon/lecture-python.myst#947). Aligns the 8 orphaned files with the source reorganisation of Nov 2025 so the resync engine can map them.
Renamed (translation preserved under the new slug; content resync follows in the Track B wave): cake_eating_problem→os, cake_eating_numerical→os_numerical, optgrowth→os_stochastic, ifp→ifp_egm, mccall_correlated→mccall_persist_trans. These were verified against the source rename history (commits b7c6464, b27f1eb) — note the mapping differs from the guesses in the tracking issue (optgrowth→os_stochastic, not os).
Removed: optgrowth_fast, coleman_policy_iter, egm_policy_iter were deleted upstream in the cake-eating refactor; their material now lives in new lectures (os_time_iter, os_egm, os_egm_jax) that are untranslated — Phase 2 scope. The removed translations remain recoverable from git history as seed material.
_toc.yml updated to match; no other target lecture cross-references these slugs.
Merge this before the resync-wave PRs for these five files.
🤖 Generated with Claude Code